diff options
Diffstat (limited to 'freefilesync/debian/patches/revert_buggy_gtk3_change_in_12.1.patch')
| -rw-r--r-- | freefilesync/debian/patches/revert_buggy_gtk3_change_in_12.1.patch | 281 |
1 files changed, 0 insertions, 281 deletions
diff --git a/freefilesync/debian/patches/revert_buggy_gtk3_change_in_12.1.patch b/freefilesync/debian/patches/revert_buggy_gtk3_change_in_12.1.patch deleted file mode 100644 index 360f804..0000000 --- a/freefilesync/debian/patches/revert_buggy_gtk3_change_in_12.1.patch +++ /dev/null @@ -1,281 +0,0 @@ -Description: Revert change that provokes freeze when opening dialogs - With upstream's 12.1 version, there started to be a freeze when opening - some dialogs. Upstream author identified this might come from a given change - detailed in https://freefilesync.org/forum/viewtopic.php?t=10103 - . - Until the problem is fixed upstream, this patch reverts that change. -Author: Fab Stz <fabstz-it@yahoo.fr> -Origin: self -Bug: https://freefilesync.org/forum/viewtopic.php?t=10103 -Forwarded: https://freefilesync.org/forum/viewtopic.php?t=10103 -Last-Update: 2023-09-13 -Version: 13.0 - ---- a/FreeFileSync/Source/ui/abstract_folder_picker.cpp -+++ b/FreeFileSync/Source/ui/abstract_folder_picker.cpp -@@ -127,10 +127,7 @@ AbstractFolderPickerDlg::AbstractFolderP - - //---------------------------------------------------------------------- - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - Bind(wxEVT_CHAR_HOOK, [this](wxKeyEvent& event) { onLocalKeyEvent(event); }); //dialog-specific local key events ---- a/FreeFileSync/Source/ui/batch_config.cpp -+++ b/FreeFileSync/Source/ui/batch_config.cpp -@@ -81,10 +81,7 @@ BatchDialog::BatchDialog(wxWindow* paren - Bind(wxEVT_CHAR_HOOK, [this](wxKeyEvent& event) { onLocalKeyEvent(event); }); //enable dialog-specific key events - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_buttonSaveAs->SetFocus(); ---- a/FreeFileSync/Source/ui/progress_indicator.cpp -+++ b/FreeFileSync/Source/ui/progress_indicator.cpp -@@ -221,10 +221,7 @@ CompareProgressPanel::Impl::Impl(wxFrame - m_panelErrorStats->Layout(); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - } - - -@@ -925,10 +922,6 @@ syncStat_(&syncStat) - //make sure that standard height matches ProcessPhase::binaryCompare statistics layout (== largest) - - this->GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- this->Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- this->Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif - pnl_.Layout(); - this->Center(); //call *after* dialog layout update and *before* wxWindow::Show()! - ---- a/FreeFileSync/Source/ui/small_dlgs.cpp -+++ b/FreeFileSync/Source/ui/small_dlgs.cpp -@@ -148,10 +148,6 @@ AboutDlg::AboutDlg(wxWindow* parent) : A - //-------------------------------------------------------------------------- - //have animal + text match *final* dialog width - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif - - { - const int imageWidth = (m_panelDonate->GetSize().GetWidth() - 5 - 5 - 5 /* grey border*/) / 2; -@@ -166,10 +162,7 @@ AboutDlg::AboutDlg(wxWindow* parent) : A - Bind(wxEVT_CHAR_HOOK, [this](wxKeyEvent& event) { onLocalKeyEvent(event); }); //enable dialog-specific key events - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_buttonClose->SetFocus(); //on GTK ESC is only associated with wxID_OK correctly if we set at least *any* focus at all!!! -@@ -406,11 +399,7 @@ CloudSetupDlg::CloudSetupDlg(wxWindow* p - m_checkBoxPasswordPrompt->Hide(); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() -- //=> works like a charm for GTK with window resizing problems and title bar corruption; e.g. Debian!!! --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - updateGui(); //*after* SetSizeHints when standard dialog height has been calculated -@@ -974,10 +963,7 @@ CopyToDialog::CopyToDialog(wxWindow* par - Bind(wxEVT_CHAR_HOOK, [this](wxKeyEvent& event) { onLocalKeyEvent(event); }); //enable dialog-specific key events - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_buttonOK->SetFocus(); -@@ -1091,10 +1077,7 @@ DeleteDialog::DeleteDialog(wxWindow* par - Bind(wxEVT_CHAR_HOOK, [this](wxKeyEvent& event) { onLocalKeyEvent(event); }); //enable dialog-specific key events - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_buttonOK->SetFocus(); -@@ -1234,10 +1217,7 @@ SyncConfirmationDlg::SyncConfirmationDlg - setIntValue(*m_staticTextDeleteRight, st.deleteCount<SelectSide::right>(), *m_bitmapDeleteRight, "so_delete_right_sicon"); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_buttonStartSync->SetFocus(); -@@ -1501,10 +1481,7 @@ OptionsDlg::OptionsDlg(wxWindow* parent, - updateGui(); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - //restore actual value: -@@ -1824,10 +1801,7 @@ SelectTimespanDlg::SelectTimespanDlg(wxW - Bind(wxEVT_CHAR_HOOK, [this](wxKeyEvent& event) { onLocalKeyEvent(event); }); //enable dialog-specific key events - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_buttonOkay->SetFocus(); -@@ -1923,10 +1897,7 @@ PasswordPromptDlg::PasswordPromptDlg(wxW - m_textCtrlPasswordVisible->Hide(); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - updateGui(); //*after* SetSizeHints when standard dialog height has been calculated -@@ -2009,10 +1980,7 @@ CfgHighlightDlg::CfgHighlightDlg(wxWindo - m_spinCtrlOverdueDays->SetValue(cfgHistSyncOverdueDays); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_spinCtrlOverdueDays->SetFocus(); -@@ -2080,10 +2048,7 @@ ActivationDlg::ActivationDlg(wxWindow* p - m_textCtrlOfflineActivationKey->ChangeValue(manualActivationKey); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_buttonActivateOnline->SetFocus(); -@@ -2188,12 +2153,8 @@ DownloadProgressWindow::Impl::Impl(wxWin - updateGui(); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! -- - Show(); - - //clear gui flicker: window must be visible to make this work! ---- a/FreeFileSync/Source/ui/sync_cfg.cpp -+++ b/FreeFileSync/Source/ui/sync_cfg.cpp -@@ -707,10 +707,7 @@ globalLogFolderPhrase_(globalLogFolderPh - selectFolderPairConfig(-1); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - //keep stable sizer height: change-based directions are taller than difference-based ones => init with SyncVariant::twoWay ---- a/wx+/popup_dlg.cpp -+++ b/wx+/popup_dlg.cpp -@@ -283,17 +283,12 @@ public: - //set std order after button visibility was set - setStandardButtonLayout(*bSizerStdButtons, stdBtns); - -- updateGui(); - -+ updateGui(); - - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif - Center(); //needs to be re-applied after a dialog size change! - -- - Raise(); //[!] popup may be triggered by ffs_batch job running in the background! - - if (m_buttonAccept->IsEnabled()) ---- a/wx+/tooltip.cpp -+++ b/wx+/tooltip.cpp -@@ -83,12 +83,11 @@ void Tooltip::show(const wxString& text, - } - - if (imgChanged || txtChanged) -+ { - //tipWindow_->Dimensions(); -> apparently not needed!? - tipWindow_->GetSizer()->SetSizeHints(tipWindow_); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- //=> call wxWindow::Show() to "execute" --#endif -+ //Linux: Fit() seems to be broken => call EVERY time inside show, not only if text or bmp change -> still true?!? -+ } - - const wxPoint newPos = wxTheApp->GetLayoutDirection() == wxLayout_RightToLeft ? - mousePos - wxPoint(dipToWxsize(TIP_WINDOW_OFFSET_DIP) + tipWindow_->GetSize().GetWidth(), 0) : ---- a/FreeFileSync/Source/ui/rename_dlg.cpp -+++ b/FreeFileSync/Source/ui/rename_dlg.cpp -@@ -363,10 +363,7 @@ RenameDialog::RenameDialog(wxWindow* par - - //----------------------------------------------------------- - GetSizer()->SetSizeHints(this); //~=Fit() + SetMinSize() --#ifdef __WXGTK3__ -- Show(); //GTK3 size calculation requires visible window: https://github.com/wxWidgets/wxWidgets/issues/16088 -- Hide(); //avoid old position flash when Center() moves window (asynchronously?) --#endif -+ //=> works like a charm for GTK2 with window resizing problems and title bar corruption; e.g. Debian!!! - Center(); //needs to be re-applied after a dialog size change! - - m_textCtrlNewName->SetFocus(); //[!] required *before* SetSelection() on wxGTK |