diff options
| author | psyozu <psyozu@posteo.net> | 2019-07-17 04:58:47 +0530 |
|---|---|---|
| committer | psyozu <psyozu@posteo.net> | 2019-07-17 04:58:47 +0530 |
| commit | 5458ba5fcc8fdc0f3746dc46444c420dc7f35027 (patch) | |
| tree | 412942f45c6d517834b5004e8d1f1ddf87971e43 | |
| parent | Fix flatpak build (diff) | |
| download | librewolf-linux-5458ba5fcc8fdc0f3746dc46444c420dc7f35027.tar.gz librewolf-linux-5458ba5fcc8fdc0f3746dc46444c420dc7f35027.tar.bz2 librewolf-linux-5458ba5fcc8fdc0f3746dc46444c420dc7f35027.zip | |
Make script comply with the standard bash scripting guidelines
| -rw-r--r-- | settings/toggle-settings.sh | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/settings/toggle-settings.sh b/settings/toggle-settings.sh index 8a7b30a..ff46bde 100644 --- a/settings/toggle-settings.sh +++ b/settings/toggle-settings.sh @@ -1,19 +1,21 @@ -#!/bin/bash +#!/usr/bin/env bash + +# Exit script with a non-zero exit code if: +# - any command fails (-e | --errexit) +# - any variable is unset (-u | --nounset) +# - a part of a piped sequence fails (-o pipefail) +set -euo pipefail SCRIPT_FOLDER=$(realpath $(dirname $0)); # Enable settings ------------------------------------------------------------------------------------------ -if [ "$1" = "--enable" ]; then - mv $SCRIPT_FOLDER/"[DISABLED] local-settings.js" $SCRIPT_FOLDER/local-settings.js; - mv $SCRIPT_FOLDER/"[DISABLED] policies.json" $SCRIPT_FOLDER/policies.json; - mv $SCRIPT_FOLDER/"[DISABLED] librewolf.cfg" $SCRIPT_FOLDER/librewolf.cfg; -fi - +if [[ "${1}" = "--enable" ]]; then + mv "${SCRIPT_FOLDER}/[DISABLED] local-settings.js" "${SCRIPT_FOLDER}/local-settings.js"; + mv "${SCRIPT_FOLDER}/[DISABLED] policies.json" "${SCRIPT_FOLDER}/policies.json"; + mv "${SCRIPT_FOLDER}/[DISABLED] librewolf.cfg" "${SCRIPT_FOLDER}/librewolf.cfg"; # Disable settings ------------------------------------------------------------------------------------------ -if [ "$1" = "--disable" ]; then - mv $SCRIPT_FOLDER/local-settings.js $SCRIPT_FOLDER/"[DISABLED] local-settings.js"; - mv $SCRIPT_FOLDER/policies.json $SCRIPT_FOLDER/"[DISABLED] policies.json"; - mv $SCRIPT_FOLDER/librewolf.cfg $SCRIPT_FOLDER/"[DISABLED] librewolf.cfg" ; +elif [[ "${1}" = "--disable" ]]; then + mv "${SCRIPT_FOLDER}/local-settings.js" "${SCRIPT_FOLDER}/[DISABLED] local-settings.js"; + mv "${SCRIPT_FOLDER}/policies.json" "${SCRIPT_FOLDER}/[DISABLED] policies.json"; + mv "${SCRIPT_FOLDER}/librewolf.cfg" "${SCRIPT_FOLDER}/[DISABLED] librewolf.cfg"; fi - - |