diff options
author | Joffrey BION <joffrey.bion@gmail.com> | 2017-09-05 00:15:32 +0200 |
---|---|---|
committer | Joffrey BION <joffrey.bion@gmail.com> | 2017-09-24 22:56:04 +0200 |
commit | 0bdede5142532d5af8dadb2f1b8c8bcd00ec33df (patch) | |
tree | c59297f57a556d96a6137eec9996c612f8af80d8 /doc/decisions_history.md | |
parent | Upgrade to Livedoc 1.0.2 (diff) | |
download | seven-wonders-0bdede5142532d5af8dadb2f1b8c8bcd00ec33df.tar.gz seven-wonders-0bdede5142532d5af8dadb2f1b8c8bcd00ec33df.tar.bz2 seven-wonders-0bdede5142532d5af8dadb2f1b8c8bcd00ec33df.zip |
Improve decisions history
Diffstat (limited to 'doc/decisions_history.md')
-rw-r--r-- | doc/decisions_history.md | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/doc/decisions_history.md b/doc/decisions_history.md index e055d92e..fd8d9431 100644 --- a/doc/decisions_history.md +++ b/doc/decisions_history.md @@ -40,8 +40,9 @@ running with sensible defaults. Using Immutable JS has proved to be a pain, especially because the cumbersome API is not contained in the reducers but leaks out in the React components. As far as accessing the data is concerned, I dislike not being able to do it the -native way, well supported by IDEs. What's more, using strings in such accesses is not refactoring-friendly and it -obscures the errors when we make typos. +native way (`myObj.prop`), well supported by IDEs. What's more, using strings in such accesses (`myObj.get('prop')`) +is not refactoring-friendly and it obscures the errors when we make typos. + Using `.toJS()` in each selector seemed to be a solution to avoid such accesses in React components, but it in fact destroys performance as the new props are never considered the same as the old ones, and therefore the DOM is always completely re-rendered. |