aboutsummaryrefslogtreecommitdiff
path: root/src/web
diff options
context:
space:
mode:
authorCédric Bonhomme <cedric@cedricbonhomme.org>2017-05-24 23:06:32 +0200
committerCédric Bonhomme <cedric@cedricbonhomme.org>2017-05-24 23:06:32 +0200
commitd15d428a59df925c9cb25ea869d7007132cb4416 (patch)
treed3abf3896f0253dd67b009cf9def659224b7cad4 /src/web
parentImport bookmarks from pinboard.in (diff)
downloadnewspipe-d15d428a59df925c9cb25ea869d7007132cb4416.tar.gz
newspipe-d15d428a59df925c9cb25ea869d7007132cb4416.tar.bz2
newspipe-d15d428a59df925c9cb25ea869d7007132cb4416.zip
Import from pinboard is now faster. Bookmarks are sorted by time.
Diffstat (limited to 'src/web')
-rw-r--r--src/web/models/article.py2
-rw-r--r--src/web/templates/bookmarks.html8
-rw-r--r--src/web/views/bookmark.py10
3 files changed, 12 insertions, 8 deletions
diff --git a/src/web/models/article.py b/src/web/models/article.py
index f5ef619e..e7f790ae 100644
--- a/src/web/models/article.py
+++ b/src/web/models/article.py
@@ -28,7 +28,7 @@ __license__ = "GPLv3"
from bootstrap import db
from datetime import datetime
-from sqlalchemy import asc, desc, Index
+from sqlalchemy import Index
from sqlalchemy.ext.associationproxy import association_proxy
from web.models.right_mixin import RightMixin
diff --git a/src/web/templates/bookmarks.html b/src/web/templates/bookmarks.html
index 699d7e62..96f38d26 100644
--- a/src/web/templates/bookmarks.html
+++ b/src/web/templates/bookmarks.html
@@ -1,7 +1,6 @@
{% extends "layout.html" %}
{% block content %}
<div class="container">
- <h1>{{ _('Bookmarks') }}</h1>
<ul class="list-group">
{% for bookmark in bookmarks %}
<li class="list-group-item">
@@ -11,9 +10,10 @@
</h4>
<p class="list-group-item-text">
<div class="text-muted">{{ bookmark.description }}</div>
- {{ " ".join(bookmark.tags_proxy) }}
- <a href="{{ url_for('bookmark.form', bookmark_id=bookmark.id) }}">edit</a>
- <a href="{{ url_for('bookmark.delete', bookmark_id=bookmark.id) }}">delete</a>
+ <div>{{ " ".join(bookmark.tags_proxy) }}</div>
+ {{ bookmark.time }}
+ <a class="text-muted" href="{{ url_for('bookmark.form', bookmark_id=bookmark.id) }}">edit</a>
+ <a class="text-muted" href="{{ url_for('bookmark.delete', bookmark_id=bookmark.id) }}">delete</a>
</p>
</a>
</li>
diff --git a/src/web/views/bookmark.py b/src/web/views/bookmark.py
index 87142024..d8f0ee6f 100644
--- a/src/web/views/bookmark.py
+++ b/src/web/views/bookmark.py
@@ -5,6 +5,7 @@ from flask import Blueprint, render_template, flash, \
redirect, request, url_for
from flask_babel import gettext
from flask_login import login_required, current_user
+from sqlalchemy import desc
import conf
from lib.utils import redirect_url
@@ -22,9 +23,12 @@ bookmark_bp = Blueprint('bookmark', __name__, url_prefix='/bookmark')
@login_required
def list():
"Lists the bookmarks."
+ head_titles = ["Bookmarks"]
bookmark_contr = BookmarkController(current_user.id)
return render_template('bookmarks.html',
- bookmarks=BookmarkController(current_user.id).read().order_by('time'))
+ head_titles=head_titles,
+ bookmarks=BookmarkController(current_user.id) \
+ .read().order_by(desc('time')))
@bookmark_bp.route('/create', methods=['GET'])
@@ -135,7 +139,7 @@ def import_pinboard():
nb_bookmarks = import_pinboard_json(current_user, bookmarks.read())
flash(gettext("%(nb_bookmarks)s bookmarks successfully imported.",
nb_bookmarks=nb_bookmarks), 'success')
- except:
+ except Exception as e:
flash(gettext('Error when importing bookmarks.'), 'error')
-
+
return redirect(redirect_url())
bgstack15