diff options
| author | Vadim Zhukov <persgray@gmail.com> | 2015-05-05 02:49:28 +0300 |
|---|---|---|
| committer | Vadim Zhukov <persgray@gmail.com> | 2015-05-05 02:49:28 +0300 |
| commit | 0a5b8e32467c9c388d74a53ed69aed8275a10098 (patch) | |
| tree | 486e0a6c679a424377a3b2c23d0a250b133378d5 /libLumina/LuminaX11.cpp | |
| parent | Add a (commented out) experimental feature for tagging all the various deskto... (diff) | |
| download | lumina-0a5b8e32467c9c388d74a53ed69aed8275a10098.tar.gz lumina-0a5b8e32467c9c388d74a53ed69aed8275a10098.tar.bz2 lumina-0a5b8e32467c9c388d74a53ed69aed8275a10098.zip | |
Don't try to free(3) a pointer to stack.
GCC warning helped to spot a real bug: near line 1185 of
libLumina/LuminaX11.cpp there is a call: `free(&hints);`, - but the
"hints" is allocated on the stack a few lines above. This looks
like a copy-paste error, since other free(&hints) instances look
like sane (unless I've missed something, of course).
Diffstat (limited to 'libLumina/LuminaX11.cpp')
| -rw-r--r-- | libLumina/LuminaX11.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/libLumina/LuminaX11.cpp b/libLumina/LuminaX11.cpp index 429a8ba5..3ee3c918 100644 --- a/libLumina/LuminaX11.cpp +++ b/libLumina/LuminaX11.cpp @@ -1182,8 +1182,6 @@ void LXCB::SetAsPanel(WId win){ qDebug() << " -- Set no inputs flag"; xcb_icccm_wm_hints_set_input(&hints, False); //set no input focus xcb_icccm_set_wm_hints(QX11Info::connection(), win, &hints); //save hints back to window - qDebug() << " -- Free the hints structure"; - free(&hints); //free up hints structure } // - Remove WM_TAKE_FOCUS from the WM_PROTOCOLS for the window // - - Generate the necessary atoms |