From f5a68cdb7f4b1c6e82c879d5afd7057959246893 Mon Sep 17 00:00:00 2001 From: David King Date: Mon, 25 Apr 2022 13:42:41 +0100 Subject: msg: Fix maximum width to 60 characters Commit 3b64d05e8a1aae1581d2bec7288d80ac4699e1b1 mentioned that labels in message dialogs were set to a maximum width of 60 characters, with inspiration from GtkMessageDialog, but in fact a typo meant that they were set to both a width and maximum width of just 10 characters. This lead to text layout problems, which can be fixed by using the intended maximum of 60 characters. https://bugzilla.redhat.com/show_bug.cgi?id=2053530 --- src/msg.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/msg.c b/src/msg.c index 496fe185..92651525 100644 --- a/src/msg.c +++ b/src/msg.c @@ -202,12 +202,10 @@ zenity_msg (ZenityData *data, ZenityMsgData *msg_data) { if (data->width > -1) gtk_widget_set_size_request (GTK_WIDGET (text), data->width, -1); else if (!msg_data->ellipsize && !msg_data->no_wrap) { - // the magic number 60 is picked from gtk+/gtk/ui/gtkmessagedialog.ui - // however, 60 would increase the distance between the icon and the - // text, - // decreasing to 10 fix it. + /* The magic number 60 is taken from gtk+/gtk/ui/gtkmessagedialog.ui + with 10 as a minimum width. */ gtk_label_set_width_chars (GTK_LABEL (text), 10); - gtk_label_set_max_width_chars (GTK_LABEL (text), 10); + gtk_label_set_max_width_chars (GTK_LABEL (text), 60); } if (data->modal) -- cgit