From 75da25cad974c3053f142d8e50294b00d6d4828e Mon Sep 17 00:00:00 2001 From: Joffrey BION Date: Sun, 9 Jul 2017 23:28:47 +0200 Subject: Finish removing unnecessary Principal comments --- .../sevenwonders/controllers/GameBrowserControllerTest.java | 8 -------- .../org/luxons/sevenwonders/controllers/HomeControllerTest.java | 1 - 2 files changed, 9 deletions(-) diff --git a/backend/src/test/java/org/luxons/sevenwonders/controllers/GameBrowserControllerTest.java b/backend/src/test/java/org/luxons/sevenwonders/controllers/GameBrowserControllerTest.java index 9ebcfd2b..6c971517 100644 --- a/backend/src/test/java/org/luxons/sevenwonders/controllers/GameBrowserControllerTest.java +++ b/backend/src/test/java/org/luxons/sevenwonders/controllers/GameBrowserControllerTest.java @@ -39,7 +39,6 @@ public class GameBrowserControllerTest { @Test public void listGames_initiallyEmpty() { - // the Principal interface just contains a getName() method Principal principal = new TestPrincipal("testuser"); Collection games = gameBrowserController.listGames(principal); assertTrue(games.isEmpty()); @@ -48,7 +47,6 @@ public class GameBrowserControllerTest { @Test public void createGame_success() { Player player = playerRepository.createOrUpdate("testuser", "Test User"); - // the Principal interface just contains a getName() method Principal principal = new TestPrincipal("testuser"); CreateGameAction action = new CreateGameAction(); @@ -67,7 +65,6 @@ public class GameBrowserControllerTest { @Test(expected = PlayerNotFoundException.class) public void createGame_failsForUnknownPlayer() { - // the Principal interface just contains a getName() method Principal principal = new TestPrincipal("unknown"); CreateGameAction action = new CreateGameAction(); @@ -79,7 +76,6 @@ public class GameBrowserControllerTest { @Test(expected = UserAlreadyInGameException.class) public void createGame_failsWhenAlreadyInGame() { playerRepository.createOrUpdate("testuser", "Test User"); - // the Principal interface just contains a getName() method Principal principal = new TestPrincipal("testuser"); CreateGameAction createGameAction1 = new CreateGameAction(); @@ -98,7 +94,6 @@ public class GameBrowserControllerTest { @Test public void joinGame_success() { Player owner = playerRepository.createOrUpdate("testowner", "Test User Owner"); - // the Principal interface just contains a getName() method Principal ownerPrincipal = new TestPrincipal("testowner"); CreateGameAction createGameAction = new CreateGameAction(); createGameAction.setGameName("Test Game"); @@ -106,7 +101,6 @@ public class GameBrowserControllerTest { Lobby createdLobby = gameBrowserController.createGame(createGameAction, ownerPrincipal); Player joiner = playerRepository.createOrUpdate("testjoiner", "Test User Joiner"); - // the Principal interface just contains a getName() method Principal joinerPrincipal = new TestPrincipal("testjoiner"); JoinGameAction joinGameAction = new JoinGameAction(); joinGameAction.setGameId(createdLobby.getId()); @@ -121,7 +115,6 @@ public class GameBrowserControllerTest { @Test(expected = UserAlreadyInGameException.class) public void joinGame_failsWhenAlreadyInGame() { playerRepository.createOrUpdate("testowner", "Test User Owner"); - // the Principal interface just contains a getName() method Principal ownerPrincipal = new TestPrincipal("testowner"); CreateGameAction createGameAction = new CreateGameAction(); createGameAction.setGameName("Test Game"); @@ -129,7 +122,6 @@ public class GameBrowserControllerTest { Lobby createdLobby = gameBrowserController.createGame(createGameAction, ownerPrincipal); playerRepository.createOrUpdate("testjoiner", "Test User Joiner"); - // the Principal interface just contains a getName() method Principal joinerPrincipal = new TestPrincipal("testjoiner"); JoinGameAction joinGameAction = new JoinGameAction(); joinGameAction.setGameId(createdLobby.getId()); diff --git a/backend/src/test/java/org/luxons/sevenwonders/controllers/HomeControllerTest.java b/backend/src/test/java/org/luxons/sevenwonders/controllers/HomeControllerTest.java index 0e9cfadf..3104bf4a 100644 --- a/backend/src/test/java/org/luxons/sevenwonders/controllers/HomeControllerTest.java +++ b/backend/src/test/java/org/luxons/sevenwonders/controllers/HomeControllerTest.java @@ -20,7 +20,6 @@ public class HomeControllerTest { ChooseNameAction action = new ChooseNameAction(); action.setPlayerName("Test User"); - // the Principal interface just contains a getName() method Principal principal = new TestPrincipal("testuser"); Player player = homeController.chooseName(action, principal); -- cgit