From 5f66e6465d3822b150898de2a7fb8df39ed7fdc6 Mon Sep 17 00:00:00 2001 From: François Schmidts Date: Sun, 11 Oct 2015 23:34:33 +0200 Subject: removing misplaced stuffs from views, more controllers use --- pyaggr3g470r/views/admin.py | 166 ++++++++++++++++++++ pyaggr3g470r/views/user.py | 152 ++++++++++++++++++ src/runserver.py | 3 + src/web/controllers/abstract.py | 2 +- src/web/controllers/user.py | 25 +++ src/web/models/user.py | 10 +- src/web/templates/admin/dashboard.html | 18 ++- src/web/templates/home.html | 2 +- src/web/templates/layout.html | 6 +- src/web/utils.py | 2 +- src/web/views/__init__.py | 2 + src/web/views/views.py | 274 +-------------------------------- 12 files changed, 368 insertions(+), 294 deletions(-) create mode 100644 pyaggr3g470r/views/admin.py create mode 100644 pyaggr3g470r/views/user.py diff --git a/pyaggr3g470r/views/admin.py b/pyaggr3g470r/views/admin.py new file mode 100644 index 00000000..744f3523 --- /dev/null +++ b/pyaggr3g470r/views/admin.py @@ -0,0 +1,166 @@ +from flask import (Blueprint, g, render_template, redirect, + flash, url_for, request) +from flask.ext.babel import gettext +from flask.ext.login import login_required + +from flask.ext.principal import Permission, RoleNeed + +from pyaggr3g470r.lib.utils import redirect_url +from pyaggr3g470r.models import Role +from pyaggr3g470r.controllers import UserController, ArticleController + +from pyaggr3g470r.forms import InformationMessageForm, UserForm +from pyaggr3g470r import notifications + +admin_bp = Blueprint('admin', __name__, url_prefix='/admin') +admin_permission = Permission(RoleNeed('admin')) + + +@admin_bp.route('/dashboard', methods=['GET', 'POST']) +@login_required +@admin_permission.require(http_exception=403) +def dashboard(): + """ + Adminstrator's dashboard. + """ + form = InformationMessageForm() + + if request.method == 'POST': + if form.validate(): + try: + notifications.information_message(form.subject.data, + form.message.data) + except Exception as error: + flash(gettext( + 'Problem while sending email: %(error)s', error=error), + 'danger') + + users = UserController().read() + return render_template('admin/dashboard.html', + users=users, current_user=g.user, form=form) + + +@admin_bp.route('/user/create', methods=['GET']) +@admin_bp.route('/user/edit/', methods=['GET']) +@login_required +@admin_permission.require(http_exception=403) +def user_form(user_id=None): + if user_id is not None: + user = UserController().get(id=user_id) + form = UserForm(obj=user) + message = gettext('Edit the user %(nick)s', nick=user.nickname) + else: + form = UserForm() + message = gettext('Add a new user') + return render_template('/admin/create_user.html', + form=form, message=message) + + +@admin_bp.route('/user/create', methods=['POST']) +@admin_bp.route('/user/edit/', methods=['POST']) +@login_required +@admin_permission.require(http_exception=403) +def process_user_form(user_id=None): + """ + Create or edit a user. + """ + form = UserForm() + user_contr = UserController() + + if not form.validate(): + return render_template('/admin/create_user.html', form=form, + message=gettext('Some errors were found')) + + role_user = Role.query.filter(Role.name == "user").first() + if user_id is not None: + # Edit a user + user_contr.update({'id': user_id}, + {'nickname': form.nickname.data, + 'email': form.email.data, + 'password': form.password.data, + 'refresh_rate': form.refresh_rate.data}) + user = user_contr.get(id=user_id) + flash(gettext('User %(nick)s successfully updated', + nick=user.nickname), 'success') + else: + # Create a new user + user = user_contr.create(nickname=form.nickname.data, + email=form.email.data, + password=form.password.data, + roles=[role_user], + refresh_rate=form.refresh_rate.data, + activation_key="") + flash(gettext('User %(nick)s successfully created', + nick=user.nickname), 'success') + return redirect(url_for('admin.user_form', user_id=user.id)) + + +@admin_bp.route('/user/', methods=['GET']) +@login_required +@admin_permission.require(http_exception=403) +def user(user_id=None): + """ + See information about a user (stations, etc.). + """ + user = UserController().get(id=user_id) + if user is not None: + article_contr = ArticleController(user_id) + return render_template('/admin/user.html', user=user, feeds=user.feeds, + article_count=article_contr.count_by_feed(), + unread_article_count=article_contr.count_by_feed(readed=False)) + + else: + flash(gettext('This user does not exist.'), 'danger') + return redirect(redirect_url()) + + +@admin_bp.route('/delete_user/', methods=['GET']) +@login_required +@admin_permission.require(http_exception=403) +def delete_user(user_id=None): + """ + Delete a user (with all its data). + """ + try: + user = UserController().delete(user_id) + flash(gettext('User %(nick)s successfully deleted', + nick=user.nickname), 'success') + except Exception as error: + flash(gettext('An error occured while trying to delete a user: ' + '%(error)', error=error), 'danger') + return redirect(redirect_url()) + + +@admin_bp.route('/toggle_user/', methods=['GET']) +@login_required +@admin_permission.require() +def toggle_user(user_id=None): + """ + Enable or disable the account of a user. + """ + user_contr = UserController() + user = user_contr.get(id=user_id) + + if user is None: + flash(gettext('This user does not exist.'), 'danger') + return redirect(url_for('admin.dashboard')) + + if user.activation_key != "": + + # Send the confirmation email + try: + notifications.new_account_activation(user) + user_contr.unset_activation_key(user.id) + message = gettext('Account of the user %(nick)s successfully ' + 'activated.', nick=user.nickname) + except Exception as error: + flash(gettext('Problem while sending activation email %(error)s:', + error=error), 'danger') + return redirect(url_for('admin.dashboard')) + + else: + user_contr.set_activation_key(user.id) + message = gettext('Account of the user %(nick)s successfully disabled', + nick=user.nickname) + flash(message, 'success') + return redirect(url_for('admin.dashboard')) diff --git a/pyaggr3g470r/views/user.py b/pyaggr3g470r/views/user.py new file mode 100644 index 00000000..cb416b5d --- /dev/null +++ b/pyaggr3g470r/views/user.py @@ -0,0 +1,152 @@ +import string +import random +from flask import (Blueprint, g, render_template, redirect, + flash, url_for, request) +from flask.ext.babel import gettext +from flask.ext.login import login_required + +import conf +from pyaggr3g470r import utils, notifications +from pyaggr3g470r.controllers import (UserController, FeedController, + ArticleController) + +from pyaggr3g470r.forms import ProfileForm, RecoverPasswordForm + +users_bp = Blueprint('users', __name__, url_prefix='/users') +user_bp = Blueprint('user', __name__, url_prefix='/user') + + +@user_bp.route('/management', methods=['GET', 'POST']) +@login_required +def management(): + """ + Display the management page. + """ + if request.method == 'POST': + if None != request.files.get('opmlfile', None): + # Import an OPML file + data = request.files.get('opmlfile', None) + if not utils.allowed_file(data.filename): + flash(gettext('File not allowed.'), 'danger') + else: + try: + nb = utils.import_opml(g.user.email, data.read()) + if conf.CRAWLING_METHOD == "classic": + utils.fetch(g.user.email, None) + flash(str(nb) + ' ' + gettext('feeds imported.'), + "success") + flash(gettext("Downloading articles..."), 'info') + except: + flash(gettext("Impossible to import the new feeds."), + "danger") + elif None != request.files.get('jsonfile', None): + # Import an account + data = request.files.get('jsonfile', None) + if not utils.allowed_file(data.filename): + flash(gettext('File not allowed.'), 'danger') + else: + try: + nb = utils.import_json(g.user.email, data.read()) + flash(gettext('Account imported.'), "success") + except: + flash(gettext("Impossible to import the account."), + "danger") + else: + flash(gettext('File not allowed.'), 'danger') + + nb_feeds = FeedController(g.user.id).read().count() + art_contr = ArticleController(g.user.id) + nb_articles = art_contr.read().count() + nb_unread_articles = art_contr.read(readed=False).count() + return render_template('management.html', user=g.user, + nb_feeds=nb_feeds, nb_articles=nb_articles, + nb_unread_articles=nb_unread_articles) + + +@user_bp.route('/profile', methods=['GET', 'POST']) +@login_required +def profile(): + """ + Edit the profile of the currently logged user. + """ + user_contr = UserController(g.user.id) + user = user_contr.get(id=g.user.id) + form = ProfileForm() + + if request.method == 'POST': + if form.validate(): + user_contr.update({'id': g.user.id}, + {'nickname': form.nickname.data, + 'email': form.email.data, + 'password': form.password.data, + 'refresh_rate': form.refresh_rate.data}) + + flash(gettext('User %(nick)s successfully updated', + nick=user.nickname), 'success') + return redirect(url_for('user.profile')) + else: + return render_template('profile.html', user=user, form=form) + + if request.method == 'GET': + form = ProfileForm(obj=user) + return render_template('profile.html', user=user, form=form) + + +@user_bp.route('/delete_account', methods=['GET']) +@login_required +def delete_account(): + """ + Delete the account of the user (with all its data). + """ + UserController(g.user.id).delete(g.user.id) + flash(gettext('Your account has been deleted.'), 'success') + return redirect(url_for('login')) + + +@user_bp.route('/confirm_account/', methods=['GET']) +def confirm_account(activation_key=None): + """ + Confirm the account of a user. + """ + user_contr = UserController() + if activation_key != "": + user = user_contr.read(activation_key=activation_key).first() + if user is not None: + user_contr.update({'id': user.id}, {'activation_key': ''}) + flash(gettext('Your account has been confirmed.'), 'success') + else: + flash(gettext('Impossible to confirm this account.'), 'danger') + return redirect(url_for('login')) + + +@user_bp.route('/recover', methods=['GET', 'POST']) +def recover(): + """ + Enables the user to recover its account when he has forgotten + its password. + """ + form = RecoverPasswordForm() + user_contr = UserController() + + if request.method == 'POST': + if form.validate(): + user = user_contr.get(email=form.email.data) + characters = string.ascii_letters + string.digits + password = "".join(random.choice(characters) + for x in range(random.randint(8, 16))) + user.set_password(password) + user_contr.update({'id': user.id}, {'password': password}) + + # Send the confirmation email + try: + notifications.new_password_notification(user, password) + flash(gettext('New password sent to your address.'), 'success') + except Exception as error: + flash(gettext('Problem while sending your new password: ' + '%(error)s', error=error), 'danger') + + return redirect(url_for('login')) + return render_template('recover.html', form=form) + + if request.method == 'GET': + return render_template('recover.html', form=form) diff --git a/src/runserver.py b/src/runserver.py index b355d7d1..d0bfa533 100755 --- a/src/runserver.py +++ b/src/runserver.py @@ -54,6 +54,9 @@ with application.app_context(): application.register_blueprint(views.categories_bp) application.register_blueprint(views.category_bp) application.register_blueprint(views.icon_bp) + application.register_blueprint(views.admin_bp) + application.register_blueprint(views.users_bp) + application.register_blueprint(views.user_bp) if __name__ == '__main__': diff --git a/src/web/controllers/abstract.py b/src/web/controllers/abstract.py index f33d241e..99d92ff3 100644 --- a/src/web/controllers/abstract.py +++ b/src/web/controllers/abstract.py @@ -84,7 +84,7 @@ class AbstractController(object): def create(self, **attrs): assert self._user_id_key is None or self._user_id_key in attrs \ - or self.user_id is not None, \ + or self.user_id is None, \ "You must provide user_id one way or another" if self._user_id_key is not None and self._user_id_key not in attrs: diff --git a/src/web/controllers/user.py b/src/web/controllers/user.py index 3f96b185..d8bf1fa1 100644 --- a/src/web/controllers/user.py +++ b/src/web/controllers/user.py @@ -1,3 +1,6 @@ +import random +import hashlib +from werkzeug import generate_password_hash from .abstract import AbstractController from web.models import User @@ -5,3 +8,25 @@ from web.models import User class UserController(AbstractController): _db_cls = User _user_id_key = 'id' + + def unset_activation_key(self, obj_id): + self.update({'id': obj_id}, {'activation_key': ""}) + + def set_activation_key(self, obj_id): + key = str(random.getrandbits(256)).encode("utf-8") + key = hashlib.sha512(key).hexdigest()[:86] + self.update({'id': obj_id}, {'activation_key': key}) + + def _handle_password(self, attrs): + if attrs.get('password'): + attrs['pwdhash'] = generate_password_hash(attrs.pop('password')) + elif 'password' in attrs: + del attrs['password'] + + def create(self, **attrs): + self._handle_password(attrs) + return super().create(**attrs) + + def update(self, filters, attrs): + self._handle_password(attrs) + return super().update(filters, attrs) diff --git a/src/web/models/user.py b/src/web/models/user.py index c5e70036..d1b9c568 100644 --- a/src/web/models/user.py +++ b/src/web/models/user.py @@ -30,7 +30,7 @@ import re import random import hashlib from datetime import datetime -from werkzeug import generate_password_hash, check_password_hash +from werkzeug import check_password_hash from flask.ext.login import UserMixin from bootstrap import db @@ -63,12 +63,6 @@ class User(db.Model, UserMixin): """ return self.id - def set_password(self, password): - """ - Hash the password of the user. - """ - self.pwdhash = generate_password_hash(password) - def check_password(self, password): """ Check the password of the user. @@ -79,7 +73,7 @@ class User(db.Model, UserMixin): """ Return True if the user has administrator rights. """ - return len([role for role in self.roles if role.name == "admin"]) != 0 + return "admin" in [role.name for role in self.roles] def __eq__(self, other): return self.id == other.id diff --git a/src/web/templates/admin/dashboard.html b/src/web/templates/admin/dashboard.html index 25bd3883..2436c955 100644 --- a/src/web/templates/admin/dashboard.html +++ b/src/web/templates/admin/dashboard.html @@ -20,29 +20,31 @@ {{ loop.index }} {% if user.id == current_user.id %} - {{ user.nickname }} (It's you!) + {{ user.nickname }} (It's you!) {% else %} - {{ user.nickname }} + {{ user.nickname }} {% endif %} {{ user.email }} {{ user.last_seen }} - - + + {% if user.id != current_user.id %} + {% if user.activation_key == "" %} - + {% else %} - + {% endif %} - + + {% endif %} {% endfor %} -{{ _('Add a new user') }} +{{ _('Add a new user') }}

{{ _('Send notification messages') }}

{{ form.hidden_tag() }} diff --git a/src/web/templates/home.html b/src/web/templates/home.html index 86d96e94..6b136870 100644 --- a/src/web/templates/home.html +++ b/src/web/templates/home.html @@ -3,7 +3,7 @@ {% if feeds|count == 0 %}

{{ _("You don't have any feeds.") }}

-

{{ _('Add some') }}, {{ _('or') }} {{ _('upload an OPML file.') }}

+

{{ _('Add some') }}, {{ _('or') }} {{ _('upload an OPML file.') }}

{% else %}
diff --git a/src/web/templates/layout.html b/src/web/templates/layout.html index cf2498e2..eb213ca5 100644 --- a/src/web/templates/layout.html +++ b/src/web/templates/layout.html @@ -81,12 +81,12 @@