From 63d497b625c6edfd00971479c6c68c3f26b48ada Mon Sep 17 00:00:00 2001 From: Martin Stransky Date: Thu, 12 May 2016 12:21:15 +0200 Subject: Added fix for rhbz#1332821 - Crash on Select in Open --- rhbz-1291190-appchooser-crash.patch | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) (limited to 'rhbz-1291190-appchooser-crash.patch') diff --git a/rhbz-1291190-appchooser-crash.patch b/rhbz-1291190-appchooser-crash.patch index 7a432d0..be3ccd8 100644 --- a/rhbz-1291190-appchooser-crash.patch +++ b/rhbz-1291190-appchooser-crash.patch @@ -1,18 +1,14 @@ -diff -up firefox-44.0/widget/gtk/nsApplicationChooser.cpp.appchooser-crash firefox-44.0/widget/gtk/nsApplicationChooser.cpp ---- firefox-44.0/widget/gtk/nsApplicationChooser.cpp.appchooser-crash 2016-01-24 00:23:50.000000000 +0100 -+++ firefox-44.0/widget/gtk/nsApplicationChooser.cpp 2016-02-03 17:17:50.891127905 +0100 -@@ -112,7 +112,13 @@ void nsApplicationChooser::Done(GtkWidge +diff -up firefox-46.0.1/widget/gtk/nsApplicationChooser.cpp.appchooser-crash firefox-46.0.1/widget/gtk/nsApplicationChooser.cpp +--- firefox-46.0.1/widget/gtk/nsApplicationChooser.cpp.appchooser-crash 2016-05-03 07:31:12.000000000 +0200 ++++ firefox-46.0.1/widget/gtk/nsApplicationChooser.cpp 2016-05-12 12:17:44.043729262 +0200 +@@ -112,7 +112,9 @@ void nsApplicationChooser::Done(GtkWidge // A "response" signal won't be sent again but "destroy" will be. g_signal_handlers_disconnect_by_func(chooser, FuncToGpointer(OnDestroy), this); - gtk_widget_destroy(chooser); -+ // GTK 3.18 has a problem with destroying dialog at this stage for some reason. ++ // GTK >= 3.18 has a problem with destroying dialog at this stage for some reason. + // We're going to hide the dialog in this case as a workaround. -+ if (gtk_major_version == 3 && gtk_minor_version == 18) { -+ gtk_widget_hide(chooser); -+ } else { -+ gtk_widget_destroy(chooser); -+ } ++ gtk_widget_hide(chooser); if (mCallback) { mCallback->Done(localHandler); -- cgit